Change in openvpn[master]: openvpnmsica: Fix setting of iTicks in schedule_adapter_delete
A message that is not in the archive (sent off-list or not yet received): gerrit.1775324949000.I4d6501ddfb321f57a76841f29ff92c5a412908bb@...2715...
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1608?usp=email
to review the following change.
Change subject: openvpnmsica: Fix setting of iTicks in schedule_adapter_delete
......................................................................
openvpnmsica: Fix setting of iTicks in schedule_adapter_delete
Increase the integer, not the pointer.
Found by cppcheck.
---
M src/openvpnmsica/openvpnmsica.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/08/1608/1
src/openvpnmsica/openvpnmsica.c +1 -1
@@ -613,7 +613,7 @@msica_arg_seq_add_tail (seq, szArgument); } - iTicks +=MSICA_ADAPTER_TICK_SIZE ; + *iTicks +=MSICA_ADAPTER_TICK_SIZE ;break ;/* Adapter names are unique. There should be no other adapter with this name. */ } }
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1608?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4d6501ddfb321f57a76841f29ff92c5a412908bb
Gerrit-Change-Number: 1608
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1608?usp=email )
Change subject: openvpnmsica: Fix setting of iTicks in schedule_adapter_delete
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1608?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4d6501ddfb321f57a76841f29ff92c5a412908bb
Gerrit-Change-Number: 1608
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Sat, 04 Apr 2026 20:35:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
PATCH 1/1 openvpnmsica: Fix setting of iTicks in schedule_adapter_delete
In reply to a message not in the archiveFrom: Frank Lichtenheld <[email protected]...>
Increase the integer, not the pointer.
Found by cppcheck.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1608
---
This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1608
This mail reflects revision 1 of this Change.
Acked-by according to Gerrit (reflected above):
Gert Doering <[email protected]...>
src/openvpnmsica/openvpnmsica.c +1 -1
@@ -613,7 +613,7 @@msica_arg_seq_add_tail (seq, szArgument); } - iTicks +=MSICA_ADAPTER_TICK_SIZE ; + *iTicks +=MSICA_ADAPTER_TICK_SIZE ;break ;/* Adapter names are unique. There should be no other adapter with this name. */ } }
[Openvpn-devel] [PATCH applied] Re: openvpnmsica: Fix setting of iTicks in schedule_adapter_delete
Good find. A very clear bug, so goes back to release/2.7 and even release/2.6 - now it does not really have much consequences except progress bar not working correctly on uninstall... but still.
Your patch has been applied to the master, release/2.7 and release/2.6 branch.
commit 4494a343967e9cd0fcf32f167b22706512c8c68c (master) commit f4669642581934d317707e56c297d777946ce5c4 (release/2.7) commit 246bc0e8d022920889a69d19e2e534b9560c8d9a (release/2.6)
Author: Frank Lichtenheld Date: Sat Apr 4 22:35:19 2026 +0200
openvpnmsica: Fix setting of iTicks in schedule_adapter_delete
Signed-off-by: Frank Lichtenheld <[email protected]...>
Acked-by: Gert Doering <[email protected]...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1608
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36476.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1608?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: openvpnmsica: Fix setting of iTicks in schedule_adapter_delete
......................................................................
openvpnmsica: Fix setting of iTicks in schedule_adapter_delete
Increase the integer, not the pointer.
Found by cppcheck.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1608
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36476.html
---
M src/openvpnmsica/openvpnmsica.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/08/1608/2
src/openvpnmsica/openvpnmsica.c +1 -1
@@ -613,7 +613,7 @@msica_arg_seq_add_tail (seq, szArgument); } - iTicks +=MSICA_ADAPTER_TICK_SIZE ; + *iTicks +=MSICA_ADAPTER_TICK_SIZE ;break ;/* Adapter names are unique. There should be no other adapter with this name. */ } }
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1608?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4d6501ddfb321f57a76841f29ff92c5a412908bb
Gerrit-Change-Number: 1608
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1608?usp=email )
Change subject: openvpnmsica: Fix setting of iTicks in schedule_adapter_delete
......................................................................
openvpnmsica: Fix setting of iTicks in schedule_adapter_delete
Increase the integer, not the pointer.
Found by cppcheck.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1608
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36476.html
---
M src/openvpnmsica/openvpnmsica.c
1 file changed, 1 insertion(+), 1 deletion(-)
src/openvpnmsica/openvpnmsica.c +1 -1
@@ -613,7 +613,7 @@msica_arg_seq_add_tail (seq, szArgument); } - iTicks +=MSICA_ADAPTER_TICK_SIZE ; + *iTicks +=MSICA_ADAPTER_TICK_SIZE ;break ;/* Adapter names are unique. There should be no other adapter with this name. */ } }
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1608?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4d6501ddfb321f57a76841f29ff92c5a412908bb
Gerrit-Change-Number: 1608
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>